Skip to content

Report relation cache sizes in --diagnostics too#58290

Closed
jakebailey wants to merge 1 commit intomicrosoft:mainfrom
jakebailey:diagnostic-cache-sizes
Closed

Report relation cache sizes in --diagnostics too#58290
jakebailey wants to merge 1 commit intomicrosoft:mainfrom
jakebailey:diagnostic-cache-sizes

Conversation

@jakebailey
Copy link
Copy Markdown
Member

This would be helpful for microsoft/typescript-benchmarking#58, as passing --extendedDiagnostics turns on tracing which slows down the compiler (not great for benchmarking).

But, maybe this is too much info for the more generic --diagnostics printout.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Apr 22, 2024
@jakebailey jakebailey marked this pull request as draft April 23, 2024 22:19
@DanielRosenwasser
Copy link
Copy Markdown
Member

But, maybe this is too much info for the more generic --diagnostics printout.

I might be wrong, but I think the only reason --diagnostics doesn't just do the same as --extendedDiagnostics is because we didn't want to break existing tools that parsed the output (and possibly that the latter measures things a little incorrectly?).

@jakebailey
Copy link
Copy Markdown
Member Author

Yeah, we talked about this in the meeting. It's now a lot easier to backfill data so we can change things, but the main problem is that extendedDiagnostics requires native performance events which slows down the benchmarks and makes them less realistic (since as we add more trace points, the perf gets worse with the flag on, but not for any actual user).

@jakebailey jakebailey closed this Jun 30, 2025
@microsoft microsoft locked as resolved and limited conversation to collaborators Jan 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants